2024. 03. 22. 23:33 keltezéssel, Dmitry Baryshkov írta: ... >> Although my opinion that it is redundant still stand, but I'm not against >> keeping the pll_type. However if we keep that, then at least we should use >> private enums (IPQ_APSS_PLL_TYPE_* or similar) for that in order to make it more >> obvious that it means a different thing than the CLK_ALPHA_PLL_TYPE_* values. >> >> This solution would be more acceptable? > > This looks like a slight overkill, but yes, it is more acceptable. The > logic should be type => functions, not the other way around. > > If that is overkill, it does not worth the change. I will drop the patch and send an updated series. Regards, Gabor
