The Qualcomm Bluetooth driver is configuring the device address in reverse order for none-ROME devices, which breaks user space tools like btmgmt and the 'local-bd-address' devicetree property. As these Qualcomm controllers lack persistent storage for the device address, boot firmware can use the 'local-bd-address' devicetree property to provide a valid address. The property should specify the address in little endian order but instead some boot firmware has been reversing the address to match the buggy Qualcomm driver. This specifically affects some Chromebook devices for which we now need to maintain compatibility with the current boot firmware. As ChromeOS updates the kernel and devicetree in lockstep, this can be done by adding a new 'qcom,local-bd-address-broken' property that can be used to determine if the firmware passes the address in the wrong byte order. [1][2] Note that this series depends on the following revert: https://lore.kernel.org/lkml/20240314084412.1127-1-johan+linaro@xxxxxxxxxx/ Also note that the devicetree patch (patch 2/4) is expected to be merged through the Qualcomm SoC tree once the other three patches have been picked up by the Bluetooth maintainers. An alternative would be if Bjorn could ack the DT patch so that everything can go in through the Bluetooth tree. Johan [1] https://lore.kernel.org/lkml/ZcuWQkmYK4Ax9kam@xxxxxxxxxx/ [2] https://lore.kernel.org/lkml/CAD=FV=WCzrh926mkiyBnKRG_+KGuOkGN6v0DgPiXhQCD3PSQ9w@xxxxxxxxxxxxxx/ Changes in v4 - add the missing type for the new vendor property to the binding - move the Trogdor DT patch after the binding patch and combine the endianness fix and Chromium workaround to avoid having any point in the series where the address is reversed on those platforms as requested by Doug Changes in v3 - add a 'qcom,local-bd-address-broken' property instead of deprecating the current WCN3991 binding - mark the bluetooth address on SC7180 Trogdor Chromebooks as broken Changes in v2 - add quirk to handle deprecated devicetree compatibles that expect broken address properties - deprecate 'qcom,wcn3991-bt' and mark it as broken Johan Hovold (4): dt-bindings: bluetooth: add 'qcom,local-bd-address-broken' arm64: dts: qcom: sc7180-trogdor: mark bluetooth address as broken Bluetooth: add quirk for broken address properties Bluetooth: qca: fix device-address endianness .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 4 ++++ arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++ drivers/bluetooth/btqca.c | 8 ++++++-- drivers/bluetooth/hci_qca.c | 10 ++++++++++ include/net/bluetooth/hci.h | 9 +++++++++ net/bluetooth/hci_sync.c | 5 ++++- 6 files changed, 35 insertions(+), 3 deletions(-) -- 2.43.2
