Re: [PATCH v2 1/4] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 3/15/2024 2:36 PM, Douglas Anderson wrote:
As documented in the description of the transfer() function of
"struct drm_dp_aux", the transfer() function can be called at any time
regardless of the state of the DP port. Specifically if the kernel has
the DP AUX character device enabled and userspace accesses
"/dev/drm_dp_auxN" directly then the AUX transfer function will be
called regardless of whether a DP device is connected.

For eDP panels we have a special rule where we wait (with a 5 second
timeout) for HPD to go high. This rule was important before all panels
drivers were converted to call wait_hpd_asserted() and actually can be
removed in a future commit.

For external DP devices we never checked for HPD. That means that
trying to access the DP AUX character device (AKA `hexdump -C
/dev/drm_dp_auxN`) would very, very slowly timeout. Specifically on my
   $ time hexdump -C /dev/drm_dp_aux0
   hexdump: /dev/drm_dp_aux0: Connection timed out
   real    0m8.200s
We want access to the drm_dp_auxN character device to fail faster than
8 seconds when no DP cable is plugged in.

Let's add a test to make transfers fail right away if a device isn't
plugged in. Rather than testing the HPD line directly, we have the
dp_display module tell us when AUX transfers should be enabled so we
can handle cases where HPD is signaled out of band like with Type C.

Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Changes in v2:
- Don't look at the HPD line directly; have dp_display call us.

  drivers/gpu/drm/msm/dp/dp_aux.c     | 20 ++++++++++++++++++++
  drivers/gpu/drm/msm/dp/dp_aux.h     |  1 +
  drivers/gpu/drm/msm/dp/dp_display.c |  4 ++++
  3 files changed, 25 insertions(+)

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux