On Mar 15, 2024 at 16:40:43 +0530, Jagadeesh Kona wrote:
> From: Abel Vesa <abel.vesa@xxxxxxxxxx>
>
> Now that genpd supports dynamically switching the control for an
> attached device between hardware- and software-mode, let's add this
> information to the genpd summary in debugfs.
"under managed by column" would be good to add as well
>
> Suggested-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
> Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
> ---
> drivers/pmdomain/core.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c
> index 70d8634dd9e8..18a101215c9c 100644
> --- a/drivers/pmdomain/core.c
> +++ b/drivers/pmdomain/core.c
> @@ -3173,6 +3173,15 @@ static void rtpm_status_str(struct seq_file *s, struct device *dev)
> seq_printf(s, "%-25s ", p);
> }
>
> +static void mode_status_str(struct seq_file *s, struct device *dev)
> +{
> + struct generic_pm_domain_data *gpd_data;
> +
> + gpd_data = to_gpd_data(dev->power.subsys_data->domain_data);
> +
> + seq_printf(s, "%20s", gpd_data->hw_mode ? "HW" : "SW");
> +}
> +
> static void perf_status_str(struct seq_file *s, struct device *dev)
> {
> struct generic_pm_domain_data *gpd_data;
> @@ -3231,6 +3240,7 @@ static int genpd_summary_one(struct seq_file *s,
> seq_printf(s, "\n %-50s ", kobj_path);
> rtpm_status_str(s, pm_data->dev);
> perf_status_str(s, pm_data->dev);
> + mode_status_str(s, pm_data->dev);
> kfree(kobj_path);
> }
>
> @@ -3247,8 +3257,8 @@ static int summary_show(struct seq_file *s, void *data)
> int ret = 0;
>
> seq_puts(s, "domain status children performance\n");
> - seq_puts(s, " /device runtime status\n");
> - seq_puts(s, "----------------------------------------------------------------------------------------------\n");
> + seq_puts(s, " /device runtime status managed by\n");
> + seq_puts(s, "------------------------------------------------------------------------------------------------------------\n");
LGTM,
Reviewed-by: Dhruva Gole <d-gole@xxxxxx>
--
Best regards,
Dhruva Gole <d-gole@xxxxxx>
