On Tue, Mar 12, 2024 at 12:04:17PM +0300, Serge Semin wrote:
> Hi Mani
>
> On Wed, Mar 06, 2024 at 03:51:57PM +0530, Manivannan Sadhasivam wrote:
> > In order to add support for Hyper DMA (HDMA), let's refactor the existing
> > dw_pcie_edma_find_chip() API by moving the common code to separate
> > functions.
> >
> > No functional change.
> >
> > Suggested-by: Serge Semin <fancer.lancer@xxxxxxxxx>
> > Reviewed-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> > Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> > drivers/pci/controller/dwc/pcie-designware.c | 40 +++++++++++++++++++++++-----
> > 1 file changed, 33 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > index 250cf7f40b85..3a26dfc5368f 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -880,7 +880,17 @@ static struct dw_edma_plat_ops dw_pcie_edma_ops = {
> > .irq_vector = dw_pcie_edma_irq_vector,
> > };
> >
> > -static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
> > +static void dw_pcie_edma_init_data(struct dw_pcie *pci)
> > +{
> > + pci->edma.dev = pci->dev;
> > +
> > + if (!pci->edma.ops)
> > + pci->edma.ops = &dw_pcie_edma_ops;
> > +
> > + pci->edma.flags |= DW_EDMA_CHIP_LOCAL;
> > +}
> > +
> > +static int dw_pcie_edma_find_mf(struct dw_pcie *pci)
> > {
> > u32 val;
> >
> > @@ -902,8 +912,6 @@ static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
> >
> > if (val == 0xFFFFFFFF && pci->edma.reg_base) {
> > pci->edma.mf = EDMA_MF_EDMA_UNROLL;
> > -
> > - val = dw_pcie_readl_dma(pci, PCIE_DMA_CTRL);
> > } else if (val != 0xFFFFFFFF) {
> > pci->edma.mf = EDMA_MF_EDMA_LEGACY;
> >
> > @@ -912,12 +920,17 @@ static int dw_pcie_edma_find_chip(struct dw_pcie *pci)
> > return -ENODEV;
> > }
> >
> > - pci->edma.dev = pci->dev;
> > + return 0;
> > +}
> >
> > - if (!pci->edma.ops)
> > - pci->edma.ops = &dw_pcie_edma_ops;
> > +static int dw_pcie_edma_find_channels(struct dw_pcie *pci)
> > +{
> > + u32 val;
> >
>
> > - pci->edma.flags |= DW_EDMA_CHIP_LOCAL;
> > + if (pci->edma.mf == EDMA_MF_EDMA_LEGACY)
> > + val = dw_pcie_readl_dbi(pci, PCIE_DMA_VIEWPORT_BASE + PCIE_DMA_CTRL);
> > + else
> > + val = dw_pcie_readl_dma(pci, PCIE_DMA_CTRL);
>
> Once again:
>
> On Tue, Feb 27, 2024 at 01:04:55PM +0530, Manivannan Sadhasivam wrote:
> > On Tue, Feb 27, 2024 at 12:00:41AM +0300, Serge Semin wrote:
> > > The entire
> > >
> > > + if (pci->edma.mf == EDMA_MF_EDMA_LEGACY)
> > > + val = dw_pcie_readl_dbi(pci, PCIE_DMA_VIEWPORT_BASE + PCIE_DMA_CTRL);
> > > + else
> > > + val = dw_pcie_readl_dma(pci, PCIE_DMA_CTRL);
> > >
> > > can be replaced with a single line
> > >
> > > + val = dw_pcie_readl_dma(pci, PCIE_DMA_CTRL);
> > >
> > > since in the legacy case (reg_base = PCIE_DMA_VIEWPORT_BASE) the
> > > pci->edma.reg_base has been initialized by now.
> > >
> >
> > Ah okay, got it!
>
Sorry, I had this change but looks like it got lost during rebase somehow. Will
bring it back.
- Mani
--
மணிவண்ணன் சதாசிவம்
