On Mon, 11 Mar 2024 at 17:46, Maxime Ripard <mripard@xxxxxxxxxx> wrote: > > Hi, > > On Sat, Mar 09, 2024 at 12:31:32PM +0200, Dmitry Baryshkov wrote: > > Setup the HDMI connector on the MSM HDMI outputs. Make use of > > atomic_check hook and of the provided Infoframe infrastructure. > > > > Note: for now only AVI Infoframes are enabled. Audio Infoframes are > > currenly handled separately. This will be fixed for the final version. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > I had a look at the driver, and it looks like mode_set and mode_valid > could use the connector_state tmds_char_rate instead of pixclock and > drm_connector_hdmi_compute_mode_clock respectively instead of > calculating it by themselves. Ack, I'll take a look.b > > We can probably remove hdmi->pixclock entirely if we manage to pass the > connector state to msm_hdmi_power_on. I'd like to defer this for a moment, I have a pending series moving MSM HDMI PHY drivers to generic PHY subsystem. However that patchset reworks the way the PHY is setup, so it doesn't make sense to rework msm_hdmi_power_on(). > > And that's unrelated to this series, but we can also remove > hdmi->hdmi_mode for drm_display_info.is_hdmi. Yes, that's the plan, once I rework the audio infoframe handling. -- With best wishes Dmitry
