On Wed, 6 Mar 2024 at 11:04, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes: > > > On WCN3990 platforms actual firmware, wlanmdsp.mbn, is sideloaded to the > > modem DSP via the TQFTPserv. These MBN files are signed by the device > > vendor, can only be used with the particular SoC or device. > > > > Unfortunately different firmware versions come with different features. > > For example firmware for SDM845 doesn't use single-chan-info-per-channel > > feature, while firmware for QRB2210 / QRB4210 requires that feature. > > > > Allow board DT files to override the subdir of the fw dir used to lookup > > the firmware-N.bin file decribing corresponding WiFi firmware. > > For example, adding firmware-name = "qrb4210" property will make the > > driver look for the firmware-N.bin first in ath10k/WCN3990/hw1.0/qrb4210 > > directory and then fallback to the default ath10k/WCN3990/hw1.0 dir. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > Changes in v2: > > - Fixed the comment about the default board name being NULL (Kalle) > > - Expanded commit message to provide examples for firmware paths (Kalle) > > - Added a note regarding board-2.bin to the commit message (Kalle) > > - Link to v1: https://lore.kernel.org/r/20240130-wcn3990-firmware-path-v1-0-826b93202964@xxxxxxxxxx > > From my point of view this looks good now but let's see what others say. > Is there a specific reason why you marked this as RFC still? No, I just forgot to remove it from the series settings, so you can consider it as final. I had one minor question in my head (but that's mostly for patches 3 and 4): in linux-firmware we will have ath10k/WCN3990/hw1.0/qcm2290 and make qrb4210 as a symlink to it. Is that fine from your POV? Or should we use sensible device names (e.g. qcom-rb1)? -- With best wishes Dmitry
