Thanks for your review Krzysztof.
On 2/8/2024 1:45 PM, Krzysztof Kozlowski wrote:
On 08/02/2024 07:28, Taniya Das wrote:
When remoteproc is used to boot the LPASS the ADSP PLL should not be
configured from the high level OS. Thus add support for property to
avoid configuring the LPASS PLL.
Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
You nicely bypassed all my filters.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
My bad, I will update the commit subject.
Anyway, I don't understand point of this commit. Aren't you now
duplicating qcom,adsp-pil-mode?
No, the expectation with pil-mode was still certain level of
configuration from HLOS LPASS clock drivers. But on the QCM6490 boards
these clocks need to be completely reserved except the resets.
Best regards,
Krzysztof
--
Thanks & Regards,
Taniya Das.
