On Tue, Feb 27, 2024 at 09:23:05PM +0530, Mukesh Ojha wrote:
> Remove redundant memory allocation failure.
>
> WARNING: Possible unnecessary 'out of memory' message
> + if (!mdata_buf) {
> + dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");
>
> Signed-off-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>
Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
This seems unrelated to the rest of the series, if you send independent
patches (or patch series) on their own it's easy to just pick them.
Regards,
Bjorn
> ---
> drivers/firmware/qcom/qcom_scm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> index 3fd89cddba3b..6c252cddd44e 100644
> --- a/drivers/firmware/qcom/qcom_scm.c
> +++ b/drivers/firmware/qcom/qcom_scm.c
> @@ -598,10 +598,9 @@ int qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size,
> */
> mdata_buf = dma_alloc_coherent(__scm->dev, size, &mdata_phys,
> GFP_KERNEL);
> - if (!mdata_buf) {
> - dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");
> + if (!mdata_buf)
> return -ENOMEM;
> - }
> +
> memcpy(mdata_buf, metadata, size);
>
> ret = qcom_scm_clk_enable();
> --
> 2.43.0.254.ga26002b62827
>
