On Wed, Feb 28, 2024 at 04:08:43PM -0600, Bjorn Helgaas wrote: > [+to Mani] > > On Fri, Feb 23, 2024 at 04:21:12PM +0100, Johan Hovold wrote: > > This series addresses a few problems with the sc8280xp PCIe > > implementation. > > ... > > > A recent commit enabling ASPM on certain Qualcomm platforms introduced > > further errors when using the Wi-Fi on the X13s as well as when > > accessing the NVMe on the CRD. The exact reason for this has not yet > > been identified, but disabling ASPM L0s makes the errors go away. This > > could suggest that either the current ASPM implementation is incomplete > > or that L0s is not supported with these devices. > > ... > > > As this series fixes a regression in 6.7 (which enabled ASPM) and fixes > > a user-reported problem with the Wi-Fi often not starting at boot, I > > think we should merge this series for the 6.8 cycle. The final patch > > enabling the GIC ITS should wait for 6.9. > > > > The DT bindings and PCI patch are expected to go through the PCI tree, > > while Bjorn A takes the devicetree updates through the Qualcomm tree. > > ... > > > Johan Hovold (12): > > dt-bindings: PCI: qcom: Allow 'required-opps' > > dt-bindings: PCI: qcom: Do not require 'msi-map-mask' > > dt-bindings: PCI: qcom: Allow 'aspm-no-l0s' > > PCI: qcom: Add support for disabling ASPM L0s in devicetree > > The ASPM patches fix a v6.7 regression, so it would be good to fix > that in v6.8. > > Mani, if you are OK with them, I can add them to for-linus for v6.8. > > What about the 'required-opps' and 'msi-map-mask' patches? If they're > important, I can merge them for v6.8, too, but it's late in the cycle > and it's not clear from the commit logs why they shouldn't wait for > v6.9. > I'm checking with Qcom HW team on the ASPM behavior. So please hold off the ASPM related patches until I get an answer. But 'required-opps' and 'msi-map-mask' patches can be applied for 6.9 (not strictly fixing anything in 6.8). - Mani -- மணிவண்ணன் சதாசிவம்