On 2/27/2024 11:14 PM, Krzysztof Kozlowski wrote: > On 28/02/2024 02:04, Unnathi Chalicheemala wrote: >> On 2/27/2024 7:47 AM, Krzysztof Kozlowski wrote: >>> On 23/02/2024 00:07, Unnathi Chalicheemala wrote: >>>> The LLCC block in SM8450, SM8550 and SM8650 have a new register >>>> space for Broadcast_AND region. This is used to check that all >>>> channels have bit set to "1", mainly in SCID activation/deactivation. >>>> >>>> Previously we were mapping only the Broadcast_OR region assuming >>>> there was only one broadcast register region. Now we also map >>>> Broadcast_AND region. >>>> >>>> Signed-off-by: Unnathi Chalicheemala <quic_uchalich@xxxxxxxxxxx> >>> >>> Why did you ignore the tags? Qualcomm upstreaming guide covers this >>> case, so please read it before sending patches. >>> >> >> I was asked to remove the Reviewed-by tag as the previous version of the >> patch gave errors on running 'make DT_CHECKER_FLAGS=-m dt_binding_check', >> that's why I dropped it. >> It was sometime ago, https://lore.kernel.org/all/d78b4bce-7bcd-4ab0-a76b-135cee3ec9b0@xxxxxxxxxx/ > > And where is it explained/mentioned? Every tag drop should be documented. > I understand, thanks for pointing out. I will record such tag drops in the change log. > Best regards, > Krzysztof >
