On Wed, Feb 28, 2024 at 08:43:53PM +0530, Krishna Chaitanya Chundru wrote: > On 2/28/2024 7:09 PM, Johan Hovold wrote: > > On Wed, Feb 28, 2024 at 12:08:37PM +0530, Krishna Chaitanya Chundru wrote: > > > > > We have limit up to 100 columns in the driver right, I am ok to change > > > to 80 but just checking if I misunderstood something. > > > > Please take a look at Documentation/process/coding-style.rst, which > > clearly states: > > > > The preferred limit on the length of a single line is 80 > > columns. > > > > Statements longer than 80 columns should be broken into sensible > > chunks, unless exceeding 80 columns significantly increases > > readability and does not hide information. > > > > So generally you should stay within 80 columns, unless not doing so > > *significantly* increases readability. (And note that making such > > decisions requires human judgement, which is why checkpatch now only > > warns about lines longer than 100 chars.) > > ok got it Johan, As checkpatch is not reporting any warnings or errors > for I misunderstood this. I will correct the comments to fit in 80 columns > in my next series. Yeah, checkpatch is great and useful, but the bottom line is that it's a tool that helps keep things relatively consistent, and a lot of that consistency just comes down to paying attention to all the surrounding code so the result looks coherent instead of a hodgepodge. Bjorn
