On Sun, 25 Feb 2024 at 19:33, Gabor Juhos <j4g8y7@xxxxxxxxx> wrote: > > The value of the 'enable_reg' field in the 'gcc_gmac0_sys_clk' > clock definition seems wrong as it is greater than the > 'max_register' value defined in the regmap configuration. > Additionally, all other gmac specific branch clock definitions > within the driver uses the same value both for the 'enable_reg' > and for the 'halt_reg' fields. > > Due to the lack of documentation the correct value is not known. > Looking into the downstream driver does not help either, as that > uses the same (presumably wrong) value [1]. > > Nevertheless, change the 'enable_reg' field of 'gcc_gmac0_sys_clk' > to use the value from the 'halt_reg' field so it follows the pattern > used in other gmac clock definitions. The change is based on the > assumption that the register layout of this clock is the same > as the other gmac clocks. > > 1. https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.4.r4/drivers/clk/qcom/gcc-ipq5018.c?ref_type=heads#L1889 > > Fixes: e3fdbef1bab8 ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018") > Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx> > --- > drivers/clk/qcom/gcc-ipq5018.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
