Re: [PATCH v3 2/3] power: supply: Add Acer Aspire 1 embedded controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Sebastian Reichel писал(а) 23.02.2024 20:04:
> Hi,
> On Fri, Feb 23, 2024 at 07:32:17PM +0500, Nikita Travkin wrote:
>> >> + This driver provides battery and AC status support for the mentioned
>> >
>> > I did not see any AC status bits?
>> I was referring to whatever ACPI spec calls "AC Adapter" but I guess
>> I should have used the word "charger" instead... Will reword this.
> But you only register a power-supply device for the battery and not
> for the AC adapter/charger. When you write "and AC status support" I
> would have expected something similar to this (that's from ACPI AC
> adapter driver):
> $ cat /sys/class/power_supply/AC/uevent

Ah, I see... Yeah looking at it one more time, I mistakenly assumed the
acpi ac code uses the same data fields as the battery but seems like it
reads the single online flag from a different place. I don't think there
is really a point on implementing that field since we can still easily
track the battery charging/discharging status so I will probably omit it
for now. Will reword the help text to not mention charger/ac adapter.

Thanks for clarifying!

> -- Sebastian

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux