Since this new platform supports both DP and eDP, it's the perfect time to drop the dual compatible (eDP and DP) and figure out a different way to specify the mode. After some off-list discussion, one suggested way was to add a 'is-edp' property to the controller node and call phy_set_mode to let the PHY know which mode it should configure itself. The PHY counterpart patchset is here: https://lore.kernel.org/all/20240220-x1e80100-phy-edp-compatible-refactor-v5-0-e8658adf5461@xxxxxxxxxx/ Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> --- Changes in v2: - Added Dmitry's R-b tag to both driver patches - Dropped the if statement around assigning the is_edp in dp_display_probe, and fixed said assignment by using the connector type from match data instead. - Moved the qcom,x1e80100-dp compatible where it belongs - Re-worded the bindings commit message to follow Bjorn's suggestion - Dropped the RFC tag as the approach doesn't seem to be questioned anymore - Link to v1: https://lore.kernel.org/r/20240221-x1e80100-display-refactor-connector-v1-0-86c0e1ebd5ec@xxxxxxxxxx --- Abel Vesa (3): dt-bindings: display: msm: dp-controller: document X1E80100 compatible drm/msm/dp: Add support for setting the eDP mode from devicetree drm/msm/dp: Add support for the X1E80100 .../bindings/display/msm/dp-controller.yaml | 6 +++++ drivers/gpu/drm/msm/dp/dp_ctrl.c | 11 +++++++++ drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 26 +++++++++++++++++++--- 4 files changed, 41 insertions(+), 3 deletions(-) --- base-commit: 4893c639cc3659cefaa675bf1e59f4e7571afb5c change-id: 20231219-x1e80100-display-refactor-connector-e1c66548cae3 Best regards, -- Abel Vesa <abel.vesa@xxxxxxxxxx>
