Hi Archit, On Mon, 18 Jan 2016 15:20:32 +0530 Archit Taneja <architt@xxxxxxxxxxxxxx> wrote: > One of the arguments passed to struct nand_chip's block_bad op is > 'getchip', which, if true, is supposed to get and select the nand device, > and later unselect and release the device. > > This op is intended to be replaceable by drivers. The drivers shouldn't > be responsible for selecting/unselecting chip. Like other ops, the chip > should already be selected before the block_bad op is called. > > Remove the getchip argument from the block_bad op and > nand_block_checkbad. Move the chip selection to nand_block_isbad, since it > is the only caller to nand_block_checkbad which requires chip selection. > > Modify nand_block_bad (the default function for the op) such that it > doesn't select the chip. > > Signed-off-by: Archit Taneja <architt@xxxxxxxxxxxxxx> > --- > v6: As suggested by Boris, remove getchip arg altogether and select the > chip in nand_block_isbad > > drivers/mtd/nand/nand_base.c | 41 +++++++++++++++++++---------------------- > include/linux/mtd/nand.h | 2 +- > 2 files changed, 20 insertions(+), 23 deletions(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 928081b..1809c20 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -317,9 +317,9 @@ static void nand_read_buf16(struct mtd_info *mtd, uint8_t *buf, int len) > * > * Check, if the block is bad. > */ > -static int nand_block_bad(struct mtd_info *mtd, loff_t ofs, int getchip) > +static int nand_block_bad(struct mtd_info *mtd, loff_t ofs) You also have to update the dummy ->block_bad() implementations in the cafe_nand, diskonchip and docg4 drivers. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
