On Sat, Feb 17, 2024 at 08:41:11PM +0100, Christian Marangi wrote: > Posting as RFC due to the massive change to a fundamental struct. > > While adding some PHY ID for Aquantia, I notice that there is a > big problem with duplicating OPs with each PHY. > > The original idea to prevent this was to use mask on the PHY ID > and identify PHY Family. Problem is that OEM started to use all > kind of PHY ID and this is not doable, hence for PHY that have > the same OPs, we have to duplicate all of them. > > This is present in Aquantia PHY, but is much more present in > other PHY, especially in the BCM7XXX where they use a big macro > for common PHYs. > > To reduce patch delta, I added the additional variable without > adding tabs as this would have resulted in a massive patch. > Also to have patch bisectable, this change has to be in one go > hence I had to use this trick to reduce patch delta. To me, this makes the code look ugly. I also expect many text editors which understand indentation will be unhappy, saying the indentation is wrong. > 64 files changed, 737 insertions(+), 291 deletions(-) These statistics are not good. If you had deleted more lines than you added, then maybe it might be an O.K. idea. Sometimes KISS is best. Andrew
