Re: [PATCH v5 06/18] dt-bindings: new: wireless: describe the ath12k PCI module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/17/2024 10:30 AM, Bartosz Golaszewski wrote:
> On Sat, Feb 17, 2024 at 7:35 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote:
>>
>> Bartosz Golaszewski <brgl@xxxxxxxx> writes:
>>
>>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>>
>>> Add device-tree bindings for the ATH12K module found in the WCN7850
>>> package.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>> ---
>>>  .../net/wireless/qcom,ath12k-pci.yaml         | 103 ++++++++++++++++++
>>>  1 file changed, 103 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
>>> new file mode 100644
>>> index 000000000000..063c576b99a0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
>>> @@ -0,0 +1,103 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +# Copyright (c) 2024 Linaro Limited
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm Technologies ath12k wireless devices (PCIe)
>>> +
>>> +maintainers:
>>> +  - Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>
>> Jeff and me are the ath12k driver maintainers so shouldn't we listed
>> here as well?
>>
> 
> Sure will do. I also noticed the subject is wrong, should have been
> "net" not "new".
> 
> Also, Jeff is not showing up for ath12k bindings in get_maintainer.pl.
> You could consider adding an N: ath12k entry to MAINTAINERS.
> 
> Bartosz
> 
>> Jeff, this reminds me that we should add you to qcom,ath10k.yaml,
>> qcom,ath11k-pci.yaml and qcom,ath11k.yaml as maintainer.

OK, I'll update those files.

And looking at MAINTAINERS, in ath10 we have an explicit path:
F:	Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml

And in ath11k we have an explicit path:
F:	Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml

However the ath11k entry is missing:
Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml

So it looks like I have a few patches:
- update my entries in MAINTAINERS to use my @kernel.org e-mail
- add myself to the existing *ath1*k*.yaml files as a maintainer
- update MAINTAINERS to replace F: *.yaml with N: ath1*k to match any
related files, including the YAML files

/jeff




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux