Re: [PATCH] soc: qcom: qcom_stats: Add DSPs and apss subsystem stats

["Maulik Shah (mkshah)" <quic_mkshah@xxxxxxxxxxx>]

On 2/15/2024 3:24 PM, Konrad Dybcio wrote:
> On 15.02.2024 10:23, Maulik Shah wrote:
> > Add SMEM items for compute, general purpose DSPs and application processor
> > subsystem stats.
> >
> > Signed-off-by: Maulik Shah <quic_mkshah@xxxxxxxxxxx>
> > ---
> >   drivers/soc/qcom/qcom_stats.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
> > index 0216fc24f2ca..c429d5154aae 100644
> > --- a/drivers/soc/qcom/qcom_stats.c
> > +++ b/drivers/soc/qcom/qcom_stats.c
> > @@ -35,11 +35,15 @@ static const struct subsystem_data subsystems[] = {
> >   	{ "wpss", 605, 13 },
> >   	{ "adsp", 606, 2 },
> >   	{ "cdsp", 607, 5 },
> > +	{ "cdsp1", 607, 12 },
> > +	{ "gpdsp0", 607, 17 },
> > +	{ "gpdsp1", 607, 18 },
> >   	{ "slpi", 608, 3 },
> >   	{ "gpu", 609, 0 },
> >   	{ "display", 610, 0 },
> >   	{ "adsp_island", 613, 2 },
> >   	{ "slpi_island", 613, 3 },
> > +	{ "apss", 631, QCOM_SMEM_HOST_ANY },
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Thanks for the review.

> Although, giving it a spin on 8280, it's not there.. It is there
> on 8450, but the reported count seems to coincide with cpuidle..
> roughly min{/sys/bus/cpu/devices/cpu*/cpuidle/state0/usage).
>
> Konrad

yes apss stats should be available from sm8450 onward and count should 
(not necessarily) coincide with 
/sys/kernel/debug/pm_genpd/power-domain-cluster/idle_states, s1 usage 
count on sm8450.

DSP stats for gdsp0/gdsp1/cdsp1 are available in sa8775p.

Thanks,
Maulik