[bug report] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dmitry Baryshkov,

This is a semi-automatic email about new static checker warnings.

    drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:746 dpu_encoder_phys_cmd_init()
    warn: variable dereferenced before check 'phys_enc->hw_intf' (see line 742)

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
   741		phys_enc->intf_mode = INTF_MODE_CMD;
   742		phys_enc->irq[INTR_IDX_UNDERRUN] = phys_enc->hw_intf->cap->intr_underrun;
                                                   ^^^^^^^^^^^^^^^^^
The patch adds an unchecked dereference

   743	
   744		cmd_enc->stream_sel = 0;
   745	
   746		if (!phys_enc->hw_intf) {
                    ^^^^^^^^^^^^^^^^^^
Too late

   747			DPU_ERROR_CMDENC(cmd_enc, "no INTF provided\n");
   748			return ERR_PTR(-EINVAL);

regards,
dan carpenter




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux