Would be nice to have a hint in the subject line about what this does. Also capitalize to match the others ("PCI: qcom: <Capitalized verb>"). On Sat, Feb 10, 2024 at 06:10:05PM +0100, Konrad Dybcio wrote: > At least on SC8280XP, if the PCIe reset is asserted, the corresponding > AUX_CLK will be stuck at 'off'. This has not been an issue so far, > since the reset is both left de-asserted by the previous boot stages > and the driver only toggles it briefly in .init. > > As part of the upcoming suspend prodecure however, the reset will be > held asserted. s/prodecure/procedure/ > Assert the reset (which may end up being a NOP in some cases) and > de-assert it back *before* turning on the clocks in preparation for > introducing RC powerdown and reinitialization. Bjorn