On 12/02/2024 12:31, Ling Xu wrote: > 在 2024/2/12 19:10, Krzysztof Kozlowski 写道: >> On 12/02/2024 12:00, Krzysztof Kozlowski wrote: >>> On 25/01/2024 11:24, Ling Xu wrote: >>>> Add dma-coherent property to fastRPC context bank nodes to pass dma >>>> sequence test in fastrpc sanity test, ensure that data integrity is >>>> maintained during DMA operations. >>>> >>>> Signed-off-by: Ling Xu <quic_lxu5@xxxxxxxxxxx> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ >>> >>> This wasn't ever tested: >>> >>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1: >>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>> >>> Ling, >>> How is this testing-patches-before-sending work in different teams? Do >>> you have such requirement? >> >> No clue if the original DTS change should be reverted or these are in >> fact DMA coherent, but let's choose one path... >> >> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@xxxxxxxxxx/T/#t >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck. I don't understand your comment. Did you read the link above? Anyway, I was asking: are you testing the patches before sending? Best regards, Krzysztof
