On Sat, 10 Feb 2024 at 03:52, Paloma Arellano <quic_parellan@xxxxxxxxxxx> wrote: > > Parity calculation is necessary for VSC SDP implementation. Therefore > create new files dp_utils.c and dp_utils.h and move the parity > calculating functions here. This ensures that they are usable by SDP > programming in both dp_catalog.c and dp_audio.c > > Changes in v2: > - Create new files dp_utils.c and dp_utils.h > - Move the parity calculation to these new files instead of > having them in dp_catalog.c and dp_catalog.h > > Signed-off-by: Paloma Arellano <quic_parellan@xxxxxxxxxxx> > --- > drivers/gpu/drm/msm/Makefile | 3 +- > drivers/gpu/drm/msm/dp/dp_audio.c | 101 +++++------------------------- > drivers/gpu/drm/msm/dp/dp_utils.c | 71 +++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_utils.h | 22 +++++++ > 4 files changed, 110 insertions(+), 87 deletions(-) > create mode 100644 drivers/gpu/drm/msm/dp/dp_utils.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_utils.h [skipped] > diff --git a/drivers/gpu/drm/msm/dp/dp_utils.h b/drivers/gpu/drm/msm/dp/dp_utils.h > new file mode 100644 > index 0000000000000..c062e29d07898 > --- /dev/null > +++ b/drivers/gpu/drm/msm/dp/dp_utils.h > @@ -0,0 +1,22 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2024, The Linux Foundation. All rights reserved. > + */ > + > +#ifndef _DP_UTILS_H_ > +#define _DP_UTILS_H_ > + > +#define HEADER_BYTE_0_BIT 0 > +#define PARITY_BYTE_0_BIT 8 > +#define HEADER_BYTE_2_BIT 0 > +#define PARITY_BYTE_2_BIT 8 > +#define HEADER_BYTE_1_BIT 16 > +#define PARITY_BYTE_1_BIT 24 > +#define HEADER_BYTE_3_BIT 16 > +#define PARITY_BYTE_3_BIT 24 Nit: it is usually 0-1-2-3 rather than 0-2-1-3. With that fixed: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > + > +u8 dp_utils_get_g0_value(u8 data); > +u8 dp_utils_get_g1_value(u8 data); > +u8 dp_utils_calculate_parity(u32 data); > + > +#endif /* _DP_UTILS_H_ */ > -- > 2.39.2 > -- With best wishes Dmitry
