Hi Jagadeesh, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jagadeesh-Kona/dt-bindings-clock-qcom-Add-video-clock-bindings-for-SM8650/20240206-194148 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next patch link: https://lore.kernel.org/r/20240206113145.31096-3-quic_jkona%40quicinc.com patch subject: [PATCH 2/5] clk: qcom: videocc-sm8550: Add support for SM8650 videocc config: arm64-randconfig-r071-20240207 (https://download.01.org/0day-ci/archive/20240209/202402091804.SdrSLt10-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202402091804.SdrSLt10-lkp@xxxxxxxxx/ smatch warnings: drivers/clk/qcom/videocc-sm8550.c:590 video_cc_sm8550_probe() error: uninitialized symbol 'offset'. vim +/offset +590 drivers/clk/qcom/videocc-sm8550.c f53153a37969c1 Jagadeesh Kona 2023-05-24 543 static int video_cc_sm8550_probe(struct platform_device *pdev) f53153a37969c1 Jagadeesh Kona 2023-05-24 544 { f53153a37969c1 Jagadeesh Kona 2023-05-24 545 struct regmap *regmap; f53153a37969c1 Jagadeesh Kona 2023-05-24 546 int ret; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 547 u32 offset; f53153a37969c1 Jagadeesh Kona 2023-05-24 548 f53153a37969c1 Jagadeesh Kona 2023-05-24 549 ret = devm_pm_runtime_enable(&pdev->dev); f53153a37969c1 Jagadeesh Kona 2023-05-24 550 if (ret) f53153a37969c1 Jagadeesh Kona 2023-05-24 551 return ret; f53153a37969c1 Jagadeesh Kona 2023-05-24 552 f53153a37969c1 Jagadeesh Kona 2023-05-24 553 ret = pm_runtime_resume_and_get(&pdev->dev); f53153a37969c1 Jagadeesh Kona 2023-05-24 554 if (ret) f53153a37969c1 Jagadeesh Kona 2023-05-24 555 return ret; f53153a37969c1 Jagadeesh Kona 2023-05-24 556 f53153a37969c1 Jagadeesh Kona 2023-05-24 557 regmap = qcom_cc_map(pdev, &video_cc_sm8550_desc); f53153a37969c1 Jagadeesh Kona 2023-05-24 558 if (IS_ERR(regmap)) { f53153a37969c1 Jagadeesh Kona 2023-05-24 559 pm_runtime_put(&pdev->dev); f53153a37969c1 Jagadeesh Kona 2023-05-24 560 return PTR_ERR(regmap); f53153a37969c1 Jagadeesh Kona 2023-05-24 561 } f53153a37969c1 Jagadeesh Kona 2023-05-24 562 5ab3df7257a04f Jagadeesh Kona 2024-02-06 563 if (of_device_is_compatible(pdev->dev.of_node, "qcom,sm8550-videocc")) { 5ab3df7257a04f Jagadeesh Kona 2024-02-06 564 video_cc_sm8550_clocks[VIDEO_CC_MVS0_SHIFT_CLK] = NULL; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 565 video_cc_sm8550_clocks[VIDEO_CC_MVS0C_SHIFT_CLK] = NULL; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 566 video_cc_sm8550_clocks[VIDEO_CC_MVS1_SHIFT_CLK] = NULL; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 567 video_cc_sm8550_clocks[VIDEO_CC_MVS1C_SHIFT_CLK] = NULL; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 568 video_cc_sm8550_clocks[VIDEO_CC_XO_CLK_SRC] = NULL; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 569 offset = 0x8140; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 570 } else if (of_device_is_compatible(pdev->dev.of_node, "qcom,sm8650-videocc")) { 5ab3df7257a04f Jagadeesh Kona 2024-02-06 571 video_cc_pll0_config.l = 0x1e; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 572 video_cc_pll0_config.alpha = 0xa000; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 573 video_cc_pll1_config.l = 0x2b; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 574 video_cc_pll1_config.alpha = 0xc000; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 575 video_cc_mvs0_clk_src.freq_tbl = ftbl_video_cc_mvs0_clk_src_sm8650; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 576 video_cc_mvs1_clk_src.freq_tbl = ftbl_video_cc_mvs1_clk_src_sm8650; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 577 offset = 0x8150; 5ab3df7257a04f Jagadeesh Kona 2024-02-06 578 } no else statement. 5ab3df7257a04f Jagadeesh Kona 2024-02-06 579 a2620539ae2529 Dmitry Baryshkov 2023-10-16 580 clk_lucid_ole_pll_configure(&video_cc_pll0, regmap, &video_cc_pll0_config); a2620539ae2529 Dmitry Baryshkov 2023-10-16 581 clk_lucid_ole_pll_configure(&video_cc_pll1, regmap, &video_cc_pll1_config); f53153a37969c1 Jagadeesh Kona 2023-05-24 582 f53153a37969c1 Jagadeesh Kona 2023-05-24 583 /* f53153a37969c1 Jagadeesh Kona 2023-05-24 584 * Keep clocks always enabled: f53153a37969c1 Jagadeesh Kona 2023-05-24 585 * video_cc_ahb_clk f53153a37969c1 Jagadeesh Kona 2023-05-24 586 * video_cc_sleep_clk f53153a37969c1 Jagadeesh Kona 2023-05-24 587 * video_cc_xo_clk f53153a37969c1 Jagadeesh Kona 2023-05-24 588 */ f53153a37969c1 Jagadeesh Kona 2023-05-24 589 regmap_update_bits(regmap, 0x80f4, BIT(0), BIT(0)); 5ab3df7257a04f Jagadeesh Kona 2024-02-06 @590 regmap_update_bits(regmap, offset, BIT(0), BIT(0)); f53153a37969c1 Jagadeesh Kona 2023-05-24 591 regmap_update_bits(regmap, 0x8124, BIT(0), BIT(0)); f53153a37969c1 Jagadeesh Kona 2023-05-24 592 f53153a37969c1 Jagadeesh Kona 2023-05-24 593 ret = qcom_cc_really_probe(pdev, &video_cc_sm8550_desc, regmap); f53153a37969c1 Jagadeesh Kona 2023-05-24 594 f53153a37969c1 Jagadeesh Kona 2023-05-24 595 pm_runtime_put(&pdev->dev); f53153a37969c1 Jagadeesh Kona 2023-05-24 596 f53153a37969c1 Jagadeesh Kona 2023-05-24 597 return ret; f53153a37969c1 Jagadeesh Kona 2023-05-24 598 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
