On 06/02/2024 20:41, Unnathi Chalicheemala wrote: > On 2/6/2024 12:34 AM, Krzysztof Kozlowski wrote: >> On 06/02/2024 08:15, Unnathi Chalicheemala wrote: >>> This series adds: >>> 1. Device tree register mapping for Broadcast_AND region in SM8450, >>> SM8550, SM8650. >>> 2. LLCC driver updates to reflect addition of Broadcast_AND regmap. >>> >>> To support CSR programming, a broadcast interface is used to program all >>> channels in a single command. Until SM8450 there was only one broadcast >>> region (Broadcast_OR) used to broadcast write and check for status bit >>> 0. From SM8450 onwards another broadcast region (Broadcast_AND) has been >>> added which checks for status bit 1. >>> >>> This series updates the device trees from SM8450 onwards to have a >>> mapping to this Broadcast_AND region. It also updates the llcc_drv_data >>> structure with a regmap for Broadcast_AND region and corrects the >>> broadcast region used to check for status bit 1. >>> >>> Merging strategy >>> ---------------- >>> >>> All patches should be merged due to LLCC DeviceTree/driver dependency. >> >> Dependency? Sorry, there cannot be a dependency between DTS and driver. >> Please fix your patchset. >> > > This is the suggested merge strategy. But I have updated the driver in v2 > to ensure that applying the driver patch alone will work with existing DTs. > Sorry for being unclear; "should" does make it sound like there is a hard > dependency. OK, anyway, the patch was not tested. Please drop my Reviewed-by and test the patch before sending. Best regards, Krzysztof
