On Fri, Feb 02, 2024 at 02:43:37AM +0100, Andrew Lunn wrote: > > + > > + phydev->drv->led_brightness_set = NULL; > > + phydev->drv->led_blink_set = NULL; > > + phydev->drv->led_hw_is_supported = NULL; > > + phydev->drv->led_hw_control_set = NULL; > > + phydev->drv->led_hw_control_get = NULL; > > I don't see how that works. You have multiple PHYs using this > driver. Some might have LEDs, some might have GPOs. But if you modify > the driver structure like this, you prevent all PHYs from having LEDs, > and maybe cause a Opps if a PHY device has already registered its > LEDs? > God you are right! Off-topic but given the effects this may cause, why the thing is not const? I assume it wouldn't make sense to add OPS based on the detected feature since it would have side effect on other PHYs that use the same driver. -- Ansuel
