Quoting Christian Marangi (2024-02-01 18:20:10) > On Thu, Feb 01, 2024 at 05:25:36PM +0100, Antoine Tenart wrote: > > Quoting Christian Marangi (2024-02-01 16:17:28) > > > + > > > + rc = __of_mdiobus_parse_phys(mdio, child, addr, scanphys); > > > > You might want to save passing scanphys down, PHYs w/o a reg property in > > a PHY package won't be "auto scanned" later. > > I might be confused by this, but isn't this already done? (passing > scanphys in each recursive call so we can set it to true if needed?) > > Also I think the scanphys should be skipped for the PHY package > (assuming we make reg mandatory, it would be an error condition and > should not be handled?) Sorry if that wasn't clear, this is what I meant. scanphys doesn't need to be set to true in a PHY package (both if we want reg to be mandatory there and because my understanding of the auto-scan code is PHYs in a PHY package won't be auto scanned anyway). Thanks, Antoine
