> + PHY package can be configured in 3 mode following this table: > + > + First Serdes mode Second Serdes mode > + Option 1 PSGMII for copper Disabled > + ports 0-4 > + Option 2 PSGMII for copper 1000BASE-X / 100BASE-FX > + ports 0-4 > + Option 3 QSGMII for copper SGMII for > + ports 0-3 copper port 4 > + > +$ref: ethernet-phy-package.yaml# > + > +properties: > + compatible: > + const: qcom,qca807x-package > + > + qcom,package-mode: > + enum: > + - qsgmii > + - psgmii There are three modes listed above, yet only two values here? Please describe how they related. > + > + qcom,tx-driver-strength: > + description: set the TX Amplifier value in mv. > + If not defined, 600mw is set by default. Looking at other bindings, it seems pretty normal to include the units in the property name: qcom,tx-driver-strength-milliwatts. Andrew