On Tue, Jan 30, 2024 at 09:52:44AM -0500, Eric Chanudet wrote: > On Thu, Jan 25, 2024 at 11:21:34AM +0530, Ninad Naik wrote: > > New memory map layout changes (by Qualcomm firmware) have brought > > in updates to base addresses and/or size for different memory regions > > like cpcucp_fw, tz-stat, and also introduces new memory regions for > > resource manager firmware. The updated memory map also fixes existing > > issues pertaining to boot up failure while running memtest, thus > > improving stability. > > > > This change brings in these corresponding memory map updates to the > > device tree for SA8775P SoC platform, which currently is in its > > development stage. > > > > Signed-off-by: Ninad Naik <quic_ninanaik@xxxxxxxxxxx> > > --- > > Changes since v1: > > - Updated commit message. > > - Fixed reserved memory node naming, by replacing underscore with > > hyphen. > > - https://lore.kernel.org/all/20240118155711.7601-1-quic_ninanaik@xxxxxxxxxxx/ > > --- > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 103 +++++++++++++++++++++++--- > > 1 file changed, 94 insertions(+), 9 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > index a7eaca33d326..2e9606c80381 100644 > > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > [snip] > > @@ -373,8 +378,43 @@ smem_mem: smem@90900000 { > > hwlocks = <&tcsr_mutex 3>; > > }; > > > > - cpucp_fw_mem: cpucp-fw@90b00000 { > > - reg = <0x0 0x90b00000 0x0 0x100000>; > > On the latest firmware I have access to (mid-January), I still trigger a > fault on that block with these changes applied: > [ 0.000000] earlycon: qcom_geni0 at MMIO 0x0000000000a8c000 (options '115200n8') > [ 0.000000] printk: legacy bootconsole [qcom_geni0] enabled > [ 0.000000] early_memtest: # of tests: 1 > [ 0.000000] 0x0000000090880000 - 0x00000000908b0000 pattern 0000000000000000 > [ 0.000000] 0x00000000908c1000 - 0x00000000908f0000 pattern 0000000000000000 > [ 0.000000] 0x0000000090b00000 - 0x0000000090c00000 pattern 0000000000000000 > [ 0.000000] Internal error: synchronous external abort: 0000000096000010 [#1] PREEMPT SMP > [snip] > > Adding back 0x90b00000-0x90bfffff as no-map passed memtest=1. A new firmware was made available end of last week. With that, the memtest completes successfully applying these changes on next-20240129. Tested-by: Eric Chanudet <echanude@xxxxxxxxxx> # sa8775p-ride -- Eric Chanudet
