Arnd Bergmann wrote:
If that's in the probe() called from it function, just use writel() everywhere, a few extra microseconds won't kill the boot time. In general, if a user would notice the difference, use the relaxed version and add a comment to explain how you proved it's correct, otherwise stay with the default accessors.
What about adding a wmb() after the last writel()? This driver does that a lot. Is that something we want to discourage? I can understand how we would want to make sure that the last write is posted before the function exits.
-- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
