Hi, On 1/19/2024 9:17 PM, Andrew Halaney wrote:
Signed-off-by: Maulik Shah <quic_mkshah@xxxxxxxxxxx> Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>Just noticed I commented on v1 when v2 was already out, sorry. Copy pasting this just to keep it on the latest thread: Two minor things: 1. Does this deserve a Fixes: tag? 2. The Signed-off-by chain here confuses me, you sent the patch so your SOB should be last, but then that makes me believe Elliot was the author which I don't think is reflected here (no From: line). Please read [0] for a bit more details [0] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Yes, this looks good to have patch, will include fixes: tag and will fix SOB in v3.
Thanks, Maulik
