On Sat, 27 Jan 2024 at 02:44, Paloma Arellano <quic_parellan@xxxxxxxxxxx> wrote: > > > On 1/25/2024 1:16 PM, Dmitry Baryshkov wrote: > > On 25/01/2024 21:38, Paloma Arellano wrote: > >> Move dpu_encoder_helper_phys_setup_cdm to dpu_encoder in preparation for > >> implementing CDM compatibility for DP. > > > > Nit: s/CDM compatibility/YUV support/. It might make sense to spell it > > out that YUV over DP requires CDM. > Ack > > > >> > >> Signed-off-by: Paloma Arellano <quic_parellan@xxxxxxxxxxx> > >> --- > >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 78 +++++++++++++++++ > >> .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 9 ++ > >> .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 84 ------------------- > >> 3 files changed, 87 insertions(+), 84 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > >> index 83380bc92a00a..6cef98f046ea6 100644 > >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > >> @@ -2114,6 +2114,84 @@ void dpu_encoder_helper_phys_cleanup(struct > >> dpu_encoder_phys *phys_enc) > >> ctl->ops.clear_pending_flush(ctl); > >> } > >> +void dpu_encoder_helper_phys_setup_cdm(struct dpu_encoder_phys > >> *phys_enc, > >> + const struct dpu_format *dpu_fmt, > >> + u32 output_type) > > > > My email client suggests that the parameters are not idented properly > > anymore. > On my editor it appears to be aligned correctly. Running checkpatch.pl > doesn't give any warnings either. So perhaps it's the email client. Checked, you are correct here. > > [skipped] > >> * dpu_encoder_phys_wb_atomic_check - verify and fixup given atomic > >> states > >> * @phys_enc: Pointer to physical encoder > >> @@ -399,7 +316,6 @@ static int dpu_encoder_phys_wb_atomic_check( > >> return > >> drm_atomic_helper_check_wb_connector_state(conn_state->connector, > >> conn_state->state); > >> } > >> - > > > > irrelevant, please drop. > Ack With this fixed: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > >> /** > >> * _dpu_encoder_phys_wb_update_flush - flush hardware update > >> * @phys_enc: Pointer to physical encoder > > -- With best wishes Dmitry
