On 1/17/2024 6:31 PM, Bjorn Andersson wrote:
In addition to the normal runtime commands, the Always On Processor (AOP) provides a number of debug commands which can be used during system debugging for things such as preventing power collapse or placing floor votes for certain resources. Some of these are documented in the Robotics RB5 "Debug AOP ADB" linked below. Provide a debugfs interface for the developer/tester to send some of these commands to the AOP, which allow the user to override the DDR frequency, preventing power collapse of cx and ddr, and prevent AOSS from going to sleep. Link: https://docs.qualcomm.com/bundle/publicresource/topics/80-88500-3/85_Debugging_AOP_ADB.html Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> --- Changes in v3: - Stop passing command string straight from userspace to the firmware - Format the commands in the driver instead - Provide a few useful commands - Link to v2: https://lore.kernel.org/linux-arm-msm/20230811205839.727373-3-quic_bjorande@xxxxxxxxxxx/ --- + qmp->debugfs_files[i] = debugfs_create_file(entry->name, 0220, + qmp->debugfs_root, + qmp, + &qmp_debugfs_fops);
With group permissions fixed: Reviewed-by: Chris Lew <quic_clew@xxxxxxxxxxx>