Re: [PATCH v2 2/6] dt-bindings: PCI: qcom,pcie-sm8450: move SM8450 to dedicated schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 26/01/2024 04:02, Rob Herring wrote:
> On Thu, 25 Jan 2024 14:03:25 +0100, Krzysztof Kozlowski wrote:
>> Move SM8450 PCIe devices from qcom,pcie.yaml binding to a dedicated file
>> to make reviewing easier.
>> This creates equivalent schema file, except:
>>  - Missing required compatible which is actually redundant.
>>  - Expecting eight MSI interrupts, instead of only one, which was
>>    incomplete hardware description.
>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/pci/qcom,pcie-sm8450.yaml  | 175 +++++++++++++++++++++
>>  .../devicetree/bindings/pci/qcom,pcie.yaml         |  67 --------
>>  2 files changed, 175 insertions(+), 67 deletions(-)
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> yamllint warnings/errors:
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-sm8450.example.dtb: pcie@1c00000: Unevaluated properties are not allowed ('#address-cells', '#interrupt-cells', '#size-cells', 'bus-range', 'device_type', 'interrupt-map', 'interrupt-map-mask', 'iommu-map', 'linux,pci-domain', 'max-link-speed', 'msi-map', 'msi-map-mask', 'num-lanes', 'perst-gpios', 'phy-names', 'phys', 'power-domains', 'ranges', 'wake-gpios' were unexpected)
> 	from schema $id:,pcie-sm8450.yaml#

I thought that's error coming from dtschema about msi-map, but in fact I
removed a bit too much in this binding when dropping if:then:.

I'll fix in v3.

Best regards,

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux