On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote:
On 15/01/2024 11:18, hui liu wrote:
On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote:
On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay
<devnull+quic_huliu.quicinc.com@xxxxxxxxxx> wrote:
From: Hui Liu <quic_huliu@xxxxxxxxxxx>
Add definition for three LEDs to make sure they can
be enabled base on QCOM LPG LED driver.
The "function" property is still placed incorrectly. Posting the next
iteration before concluding the discussion on the previous one is not
the best idea.
Do you mean I should update it as below? Seems there is no consumer to
use the function config, do we need to add now?
Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your
Makefile target).
I checked the dt-binding file of LPG LED, I will update the dts as
below, if you think it's correct, I will push v6.
+&pm8350c_pwm {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ function = LED_FUNCTION_STATUS;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_STATUS;
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ function = LED_FUNCTION_STATUS;
+ };
+};
+
Thanks,
Hui
Best regards,
Krzysztof
