Re: [PATCH] dt-bindings: remoteproc: do not override firmware-name $ref

AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> · Tue, 16 Jan 2024 13:06:19 +0100

Il 15/01/24 19:20, Krzysztof Kozlowski ha scritto:
dtschema package defines firmware-name as string-array, so individual
bindings should not make it a string but instead just narrow the number
of expected firmware file names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

... a better commit description:

The devicetree schema core defines firmware-name as a string-array:
remove the override and narrow the number of expected file names to 1.

Besides,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

---
  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml     | 4 ++--
  .../devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml  | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml      | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml       | 2 +-
  .../devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml        | 2 +-
  11 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index 09102dda4942..507f98f73d23 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -47,7 +47,7 @@ properties:
      maxItems: 1
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description:
        If present, name (or relative path) of the file within the
        firmware search path containing the firmware image used when
@@ -115,7 +115,7 @@ patternProperties:
          maxItems: 1
  
        firmware-name:
-        $ref: /schemas/types.yaml#/definitions/string
+        maxItems: 1
          description:
            If present, name (or relative path) of the file within the
            firmware search path containing the firmware image used when
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
index eb868a7ff4cd..ad45fd00ae34 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
@@ -46,7 +46,7 @@ properties:
      description: Reference to the reserved-memory for the Hexagon core
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
index c054b84fdcd5..66b455d0a8e3 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
@@ -45,7 +45,7 @@ properties:
    smd-edge: false
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
index b6bd33438584..9381c7022ff4 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
@@ -80,7 +80,7 @@ properties:
      description: Reference to the reserved-memory for the Hexagon core
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description:
        The name of the firmware which should be loaded for this remote
        processor.
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml
index 4744a37b2b5d..45ee9fbe0966 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml
@@ -42,7 +42,7 @@ properties:
      description: Reference to the reserved-memory for the Hexagon core
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
index 028287235912..758adb06c8dd 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
@@ -47,7 +47,7 @@ properties:
    smd-edge: false
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
index f7e40fb166da..c1a3cc308bdb 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
@@ -42,7 +42,7 @@ properties:
    smd-edge: false
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
index 3e4a03eb4532..7286b2baa19f 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml
@@ -36,7 +36,7 @@ properties:
      description: Reference to the reserved-memory for the Hexagon core
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
    smd-edge: false
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
index 238c6e5e67c5..d67386c50fa4 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
@@ -46,7 +46,7 @@ properties:
    smd-edge: false
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
index 53cea8e53a31..4b9fb74fb9e9 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
@@ -47,7 +47,7 @@ properties:
      description: Reference to the reserved-memory for the Hexagon core
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description: Firmware name for the Hexagon core
  
  required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
index 45eb42bd3c2c..8e033b22d28c 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
@@ -51,7 +51,7 @@ properties:
        - const: stop-ack
  
    firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
      description:
        Relative firmware image path for the WCNSS core. Defaults to
        "wcnss.mdt".










