On Mon, 15 Jan 2024 at 07:53, hui liu <quic_huliu@xxxxxxxxxxx> wrote: > On 1/12/2024 11:36 AM, Dmitry Baryshkov wrote: > > On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay > > <devnull+quic_huliu.quicinc.com@xxxxxxxxxx> wrote: > >> > >> From: Hui Liu <quic_huliu@xxxxxxxxxxx> > >> > >> Add definition for three LEDs to make sure they can > >> be enabled base on QCOM LPG LED driver. > >> > >> Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx> > >> --- > >> Changes in v4: > >> - Removed "label" definition and added "function" definition. > > > > You have removed "label", but you didn't add "function". > I added function node "function = LED_FUNCTION_STATUS;" > Don't you mean this function node? I didn't get your mean. The "function" is a property of the LED (each of them) rather than being a top-level property. > > > > BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp" > OK, I will update it to qcm6490-idp. > > > >> - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@xxxxxxxxxxx > >> > >> Changes in v3: > >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. > >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@xxxxxxxxxxx/ > >> > >> Changes in v2: > >> - Rephrased commit text and updated the nodes to board file. > >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@xxxxxxxxxxx > >> --- > >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ > >> 1 file changed, 23 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > >> index 37c91fdf3ab9..8268fad505e7 100644 > >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > >> @@ -5,6 +5,7 @@ > >> > >> /dts-v1/; > >> > >> +#include <dt-bindings/leds/common.h> > >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > >> #include "sc7280.dtsi" > >> #include "pm7325.dtsi" > >> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { > >> }; > >> }; > >> > >> +&pm8350c_pwm { > >> + function = LED_FUNCTION_STATUS; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + status = "okay"; > >> + > >> + led@1 { > >> + reg = <1>; > >> + color = <LED_COLOR_ID_RED>; > >> + }; > >> + > >> + led@2 { > >> + reg = <2>; > >> + color = <LED_COLOR_ID_GREEN>; > >> + }; > >> + > >> + led@3 { > >> + reg = <3>; > >> + color = <LED_COLOR_ID_BLUE>; > >> + }; > >> +}; > >> + > >> &qupv3_id_0 { > >> status = "okay"; > >> }; > >> > >> --- > >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > >> change-id: 20231215-lpg-4aadd374811a > >> > >> Best regards, > >> -- > >> Hui Liu <quic_huliu@xxxxxxxxxxx> > >> > >> > > > > -- With best wishes Dmitry
