Re: [PATCH v2 06/15] usb: typec: qcom-pmic-typec: fix arguments of qcom_pmic_typec_pdphy_set_roles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Wesley Cheng <quic_wcheng@xxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 06/15] usb: typec: qcom-pmic-typec: fix arguments of qcom_pmic_typec_pdphy_set_roles
From: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>
Date: Sun, 14 Jan 2024 16:13:49 +0000
Cc: linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-phy@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20240113-pmi632-typec-v2-6-182d9aa0a5b3@linaro.org>
References: <20240113-pmi632-typec-v2-0-182d9aa0a5b3@linaro.org> <20240113-pmi632-typec-v2-6-182d9aa0a5b3@linaro.org>
User-agent: Mozilla Thunderbird

On 13/01/2024 20:55, Dmitry Baryshkov wrote:

+				 (data_role == TYPEC_HOST ? MSG_CONFIG_PORT_DATA_ROLE : 0) |
+				 (power_role == TYPEC_SOURCE ? MSG_CONFIG_PORT_POWER_ROLE : 0));


Not a big fan of this syntax but... its fine too

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

References:
- [PATCH v2 00/15] usb: typec: qcom-pmic-typec: enable support for PMI632 PMIC
  - From: Dmitry Baryshkov
- [PATCH v2 06/15] usb: typec: qcom-pmic-typec: fix arguments of qcom_pmic_typec_pdphy_set_roles
  - From: Dmitry Baryshkov

Prev by Date: Re: [PATCH v2 08/15] usb: typec: qcom-pmic-typec: allow different implementations for the port backend
Next by Date: [PATCH 0/2] soc: qcom: rename rename PM2250 to PM4125
Previous by thread: Re: [PATCH v2 06/15] usb: typec: qcom-pmic-typec: fix arguments of qcom_pmic_typec_pdphy_set_roles
Next by thread: [PATCH v2 07/15] usb: typec: qcom-pmic-typec: allow different implementations for the PD PHY
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]