On 13.01.2024 06:42, Dmitry Baryshkov wrote:
> Now as all dual-lane PHYs have been migrated to a new driver, drop
> support for dual lanes configuration. If the PHY uses two lanes for USB,
> it is symthom that it should use either a combo USB+DP or a USB-C PHY
> driver.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
[...]
> - if (cfg->lanes >= 2) {
> - qmp->tx2 = devm_of_iomap(dev, np, 3, NULL);
> - if (IS_ERR(qmp->tx2))
> - return PTR_ERR(qmp->tx2);
> -
> - qmp->rx2 = devm_of_iomap(dev, np, 4, NULL);
> - if (IS_ERR(qmp->rx2))
> - return PTR_ERR(qmp->rx2);
> -
> - qmp->pcs_misc = devm_of_iomap(dev, np, 5, NULL);
> - } else {
> - qmp->pcs_misc = devm_of_iomap(dev, np, 3, NULL);
> - }
> + qmp->pcs_misc = devm_of_iomap(dev, np, 3, NULL);
>
> if (IS_ERR(qmp->pcs_misc)) {
Since you may need a new revision, you can remove the neline
above to get a nice
ret = ...
if (ret)
...
equivalent while at it
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Konrad
