Re: [PATCH RESEND v3] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/11/2024 11:38 AM, Dmitry Baryshkov wrote:
On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay
<devnull+quic_huliu.quicinc.com@xxxxxxxxxx> wrote:

From: Hui Liu <quic_huliu@xxxxxxxxxxx>

Add definition for three LEDs to make sure they can
be enabled base on QCOM LPG LED driver.

Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx>
---
Changes in v3:
- Rephrased commit text and updated the nodes to qcm6490-idp board file.

The commit message is the same as in v2.

Commit subject mentions non-existing board, "qcs6490-idp"
This devicetree file of this board has been merged in linux-next,
https://lore.kernel.org/linux-arm-msm/170157925812.1717511.10611634209504625070.b4-ty@xxxxxxxxxx/

- Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@xxxxxxxxxxx/

Changes in v2:
- Rephrased commit text and updated the nodes to board file.
- Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@xxxxxxxxxxx
---
  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++
  1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 37c91fdf3ab9..f801144a1556 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -5,6 +5,7 @@

  /dts-v1/;

+#include <dt-bindings/leds/common.h>
  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
  #include "sc7280.dtsi"
  #include "pm7325.dtsi"
@@ -414,6 +415,30 @@ vreg_bob_3p296: bob {
         };
  };

+&pm8350c_pwm {
+       #address-cells = <1>;
+       #size-cells = <0>;
+       status = "okay";
+
+       led@1 {
+               reg = <1>;
+               color = <LED_COLOR_ID_RED>;
+               label = "red";

Is there any reason why Krzysztof's review for v2 was ignored? Let me
repeat it here: "Drop labels. You already have color, so you miss
function."


+       };
+
+       led@2 {
+               reg = <2>;
+               color = <LED_COLOR_ID_GREEN>;
+               label = "green";
+       };
+
+       led@3 {
+               reg = <3>;
+               color = <LED_COLOR_ID_BLUE>;
+               label = "blue";
+       };
+};
+
  &qupv3_id_0 {
         status = "okay";
  };

---
base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
change-id: 20231215-lpg-4aadd374811a

Best regards,
--
Hui Liu <quic_huliu@xxxxxxxxxxx>








[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux