On Tue, 9 Jan 2024 at 04:04, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > Follow the example of the rest of the QMP PHY drivers and move SGMII PCS > registers to a separate header file. > > Cc: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- I'm typically opposed to the idea of putting defines used by a single driver in a separate header (for what reason?) but if that's consistent with the rest of existing drivers then ok. Bartosz