On 08/01/2024 12:32, Konrad Dybcio wrote:
-static int
-qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
+static int qcom_reset_set_assert(struct reset_controller_dev *rcdev, unsigned long id,
+ bool assert)
Personally I'd not elongate the function declaration.
{
struct qcom_reset_controller *rst;
const struct qcom_reset_map *map;
@@ -33,21 +33,17 @@ qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
map = &rst->reset_map[id];
mask = map->bitmask ? map->bitmask : BIT(map->bit);
- return regmap_update_bits(rst->regmap, map->reg, mask, mask);
+ return regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0);
and I'd probably do
u32 bits = 0;
if (assert)
bits = mask;
regmap_update_bits(rst->regmap, map->reg, mask, bits);
because I prefer for aesthetic reasons not to do ternary inputs like that.
However its up to you to change or not.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
---
bod
