Found the first issue (from first patch) while adding support for X Elite (X1E80100) which comes with more than one repeaters. The second fix is just bonus. --- Changes in v2: - The regfields is being dropped from the repeater init, but it's done in the second patch in order to not break bisectability, as it is still needed by the zero-out loop. - Added Konrad's R-b tag to the first patch. Did not add Elliot's T-b tag as the second patch has been reworked massively. - The zero-out loop is dropped now by holding a copy of the init_tlb in the container struct. This led to dropping the cfg from the container struct (see second patch commit message for more details). - Link to v1: https://lore.kernel.org/r/20240104-phy-qcom-eusb2-repeater-fixes-v1-0-047b7b6b8333@xxxxxxxxxx --- Abel Vesa (2): phy: qualcomm: eusb2-repeater: Fix the regfields for multiple instances phy: qualcomm: eusb2-repeater: Rework init to drop redundant zero-out loop drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 53 ++++++++++++++------------ 1 file changed, 28 insertions(+), 25 deletions(-) --- base-commit: e2425464bc87159274879ab30f9d4fe624b9fcd2 change-id: 20240104-phy-qcom-eusb2-repeater-fixes-c9201113032c Best regards, -- Abel Vesa <abel.vesa@xxxxxxxxxx>