do_div() does a 64-by-32 division. When the divisor is u64, do_div() truncates it to 32 bits, this means it can test non-zero and be truncated to zero for division. fix do_div.cocci warning: do_div() does a 64-by-32 division, please consider using div64_u64 instead. Signed-off-by: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c index 44b13696cf82..81853eb2993a 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -409,13 +409,13 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) out->capability = V4L2_CAP_TIMEPERFRAME; us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC; - do_div(us_per_frame, timeperframe->denominator); + div64_u64(us_per_frame, timeperframe->denominator); if (!us_per_frame) return -EINVAL; fps = (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); + div64_u64(fps, us_per_frame); inst->timeperframe = *timeperframe; inst->fps = fps; -- 2.25.1
