Re: [PATCH v5 1/2] dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/25/2023 6:35 PM, Krzysztof Kozlowski wrote:
On 22/12/2023 07:36, Krishna Kurapati wrote:
The high speed related interrupts present on QC targets are as follows:



interrupt-names:
-    minItems: 1
-    maxItems: 4
+    minItems: 2
+    maxItems: 5
qcom,select-utmi-as-pipe-clk:
      description:
@@ -361,60 +378,21 @@ allOf:
          compatible:
            contains:
              enum:
-              - qcom,ipq4019-dwc3

Why do you remove it, without adding it somewhere else. Nothing in the
commit msg explains it.


Apologies, Will check and add it back.

+              - qcom,ipq5018-dwc3
                - qcom,ipq6018-dwc3
-              - qcom,ipq8064-dwc3
                - qcom,ipq8074-dwc3
-              - qcom,msm8994-dwc3
-              - qcom,qcs404-dwc3
-              - qcom,sc7180-dwc3
-              - qcom,sdm670-dwc3
-              - qcom,sdm845-dwc3
-              - qcom,sdx55-dwc3
-              - qcom,sdx65-dwc3
-              - qcom,sdx75-dwc3
-              - qcom,sm4250-dwc3
-              - qcom,sm6350-dwc3
-              - qcom,sm8150-dwc3
-              - qcom,sm8250-dwc3
-              - qcom,sm8350-dwc3
-              - qcom,sm8450-dwc3
-              - qcom,sm8550-dwc3
-              - qcom,sm8650-dwc3
-    then:
-      properties:
-        interrupts:
-          items:
-            - description: The interrupt that is asserted
-                when a wakeup event is received on USB2 bus.
-            - description: The interrupt that is asserted
-                when a wakeup event is received on USB3 bus.
-            - description: Wakeup event on DM line.
-            - description: Wakeup event on DP line.
-        interrupt-names:
-          items:
-            - const: hs_phy_irq
-            - const: ss_phy_irq
-            - const: dm_hs_phy_irq
-            - const: dp_hs_phy_irq
-
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
                - qcom,msm8953-dwc3
-              - qcom,msm8996-dwc3
                - qcom,msm8998-dwc3
-              - qcom,sm6115-dwc3
-              - qcom,sm6125-dwc3
+              - qcom,qcm2290-dwc3
      then:
        properties:
          interrupts:
-          maxItems: 2
+          minItems: 2
+          maxItems: 3
          interrupt-names:
            items:
-            - const: hs_phy_irq
+            - const: pwr_event
+            - const: qusb2_phy
              - const: ss_phy_irq
- if:
@@ -422,37 +400,21 @@ allOf:
          compatible:
            contains:
              enum:
-              - qcom,ipq5018-dwc3
-              - qcom,ipq5332-dwc3
+              - qcom,msm8996-dwc3
+              - qcom,qcs404-dwc3
                - qcom,sdm660-dwc3
-    then:
-      properties:
-        interrupts:
-          minItems: 1
-          maxItems: 2
-        interrupt-names:
-          minItems: 1
-          items:
-            - const: hs_phy_irq
-            - const: ss_phy_irq
-
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - qcom,sc7280-dwc3
+              - qcom,sm6115-dwc3
+              - qcom,sm6125-dwc3
      then:
        properties:
          interrupts:
            minItems: 3
            maxItems: 4
          interrupt-names:
-          minItems: 3
            items:
+            - const: pwr_event
              - const: hs_phy_irq
-            - const: dp_hs_phy_irq
-            - const: dm_hs_phy_irq
+            - const: qusb2_phy

Why qusb2_phy is after hs_phy_irq? In the earlier if:then: it is the
second one.


In v3 as well, the hs_phy_irq is before qusb2_phy interrupt:
https://lore.kernel.org/all/20231211121124.4194-2-quic_kriskura@xxxxxxxxxxx/


              - const: ss_phy_irq
- if:
@@ -460,11 +422,13 @@ allOf:
          compatible:
            contains:
              enum:
+              - qcom,ipq5332-dwc3
                - qcom,sc8280xp-dwc3
                - qcom,x1e80100-dwc3
      then:
        properties:
          interrupts:
+          minItems: 3

Hm, why? This commit is unmanageable. Your commit msg is already huge
but still does not explain this. Are you sure you are fixing only one
logical thing per patch? Does not look like.


This is reordering the targets based on interrupts they have. I put it in one commit because splitting this into multiple patches breaks one thing or other. Also once I am defining permutations, I have to group targets into these combinations in the same patch. I know this is a big commit but it solves the interrupt cleanup and defines a way for future targets.

Regards,
Krishna,




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux