On Fri, 22 Dec 2023 at 00:07, Chia-I Wu <olvaffe@xxxxxxxxx> wrote:
>
> On Thu, Dec 21, 2023 at 1:55 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
> >
> > On 21.12.2023 22:48, Chia-I Wu wrote:
> > > This effectively reverts 7925ca85e9561 ("arm64: dts: qcom: sc7280: Add
> > > power-domains for cpuidle states") for sc7280-herobrine.
> > >
> > > Fixes: 7925ca85e9561 ("arm64: dts: qcom: sc7280: Add power-domains for cpuidle states")
> > > Signed-off-by: Chia-I Wu <olvaffe@xxxxxxxxx>
> > > ---
> > 0 explanations?
> Ouch. It's in the comment
>
> + * Devices that use SC7280 with TrustedFirmware-A
> + * need PSCI PC mode instead of the OSI mode provided
> + * by Qualcomm firmware.
>
> and is similar to the case with sc7180-trogdor. I can send v2 if necessary.
Absolutely necessary. And so does the accurate commit subject. The
existing one means that the whole SC7280 PSCI mode is reversed, while
instead you do it only for the TF-A platforms.
--
With best wishes
Dmitry
