On 20.12.2023 09:25, Johan Hovold wrote: > On Wed, Dec 20, 2023 at 01:30:43AM +0100, Konrad Dybcio wrote: >> Instead of magically poking at the bit0 of branch clocks' CBCR, use >> the newly introduced helper. >> >> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > >> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c >> index bfb77931e868..1ba78990b9f4 100644 >> --- a/drivers/clk/qcom/gcc-sc8280xp.c >> +++ b/drivers/clk/qcom/gcc-sc8280xp.c >> @@ -7543,21 +7543,15 @@ static int gcc_sc8280xp_probe(struct platform_device *pdev) >> goto err_put_rpm; >> } >> >> - /* >> - * Keep the clocks always-ON > > I think you should keep this part of the comment in some form > throughout, for example: > > /* Keep some clocks always on */ > qcom_branch_set_clk_en(...); > ... That's a good idea, it may not be entirely obvious for first-time readers. I'll include this. Konrad
