On Wed, Dec 20, 2023 at 01:30:45AM +0100, Konrad Dybcio wrote: > The GCC block on SM6375 is powered by the VDD_CX rail. We need to ensure > that CX is enabled to prevent unwanted power collapse As I pointed out earlier, this bit of the commit message is incorrect and misleading as the power domain will never be disabled until you enable runtime PM as part of this very patch: https://lore.kernel.org/all/ZLaSpFFBzP_Yz5yY@xxxxxxxxxxxxxxxxxxxx/ Specifically, genpd will not power off CX (at runtime) while the driver is bound when runtime PM is left disabled. > and that the > reference is dropped when unused so that the system can enter a > firmware-managed lower power state. > > Enable runtime PM to keep the power flowing only when necessary. The rest is correct. Johan
