On 18/12/2023 18:38, Dmitry Baryshkov wrote:
On 18/12/2023 13:31, Dikshita Agarwal wrote:
This patch series introduces support for Qualcomm new video acceleration
hardware architecture, used for video stream decoding/encoding. This
driver
is based on new communication protocol between video hardware and
application
processor.
This doesn't answer one important point, you have been asked for v1.
What is the actual change point between Venus and Iris? What has been
changed so much that it demands a separate driver. This is the main
question for the cover letter, which has not been answered so far.
From what I see from you bindings, the hardware is pretty close to what
we see in the latest venus generations. I asssme that there was a change
in the vcodec inteface to the firmware and other similar changes. Could
you please point out, which parts of Venus driver do no longer work or
are not applicable for sm8550?
I'd like to hear this detail too.
Grazing on some of the patches here I saw were we adding vb2 buffer ops,
which is already supported by venus.
Similar question on booting cores and doing a busy/wait instead of a
rendezvous based on an IRQ.
I feel there's a version of this series that can probably unify the
codebases but, am open to being told how that is incorrect.
---
bod