Hi, On Mon, Dec 18, 2023 at 8:37 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Fri, Dec 15, 2023 at 10:27 AM Elliot Berman <quic_eberman@xxxxxxxxxxx> wrote: > > This patch looks familiar... > https://lore.kernel.org/lkml/20230929034836.403735-1-cmllamas@xxxxxxxxxx/ > > Masahiro, can you please pick up that patch? > > Elliot, Justin, can you help test/review that patch? > Interestingly, I am getting good stack traces on mainline with a LLVM-built kernel -- both with and without that patch. It may help others, so I'll go to that patch and add my tested-by. > > > > When using LLVM as the compiler, decode_stacktrace should also use > > llvm-addr2line. Check if LLVM is set and add the appropriate > > suffix/prefix. > > > > Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx> > > --- > > scripts/decode_stacktrace.sh | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh > > index 564c5632e1a2..189b00f4e120 100755 > > --- a/scripts/decode_stacktrace.sh > > +++ b/scripts/decode_stacktrace.sh > > @@ -16,6 +16,16 @@ elif type c++filt >/dev/null 2>&1 ; then > > cppfilt_opts=-i > > fi > > > > +if [[ "${LLVM}" == "1" ]] ; then > > + addr2line="llvm-addr2line" > > +elif [[ "${LLVM}" == */ ]] ; then > > + addr2line="${LLVM}llvm-addr2line" > > +elif [[ "${LLVM}" == -* ]] ; then > > + addr2line="llvm-addr2line${LLVM}" > > +else > > + addr2line="${CROSS_COMPILE}addr2line" > > +fi > > + > > if [[ $1 == "-r" ]] ; then > > vmlinux="" > > basepath="auto" > > @@ -169,7 +179,7 @@ parse_symbol() { > > if [[ $aarray_support == true && "${cache[$module,$address]+isset}" == "isset" ]]; then > > local code=${cache[$module,$address]} > > else > > - local code=$(${CROSS_COMPILE}addr2line -i -e "$objfile" "$address" 2>/dev/null) > > + local code=$(${addr2line} -i -e "$objfile" "$address" 2>/dev/null) > > if [[ $aarray_support == true ]]; then > > cache[$module,$address]=$code > > fi > > > > --- > > base-commit: 3f7168591ebf7bbdb91797d02b1afaf00a4289b1 > > change-id: 20231214-llvm-decode-stacktrace-09538979006d > > > > Best regards, > > -- > > Elliot Berman <quic_eberman@xxxxxxxxxxx> > > > > > -- > Thanks, > ~Nick Desaulniers Thanks Justin
